Dealing with templates within code review

Related products: Software Factory

By setting a different background color for templates that are in a certain state it will make it easier to focus only on those templates that need it.

For instance think about templates that need some fixing, have or haven't changed since last review, have been reviewed and wait response of developer, alongside prefilters to make you focus on one or the other.

This not only within the Review code section, but also within the Functionality (Control procedure and templates).

 

Hello Roy,

We already made some related extensions in the 2021.2 version of the Thinkwise platform. 

Functionality > Control procedures

  • Pre 2021.2: When a control procedure is in development, and you are not the responsible developer, the control procedure and underlying templates are shown in red.
  • 2021.2: The same behaviour now also applies when a control procedure is in review, and you are not the responsible developer. The control procedure and underlying templates will also beshown in red.

Functionality > Code search

  • Pre 2021.2: Any hits on control procedure-/template code for inactive control procedures are shown in grey.
  • 2021.2: The same sort of concept is applied to hits on control procedure in development or in review, where you are not the responsible developer. Just like in the control procedure screen, these hits are shown in red.

Would this suffice for now?

Updated idea status New → Needs feedback

Hi @Roy van Uffelen,

We would still like to hear your input on the question Iasked a few weeks ago. Thanks in advance!​​​​​​

These changes help a little. Since they are only focussed on the control procedures. Probably the same could be extended towards templates.

However I get the impression that you can still not see which templates are changed. Having a conditional layout to highlight these changed templates would be really benefitial.

Also having some highlight on control procedures and templates that are used in program objects linked to changed tables could be helpful. Think about what happens when adding a calculated column. No deployment is necessary to the database, but the linked program objects have extra parameters. These have to be generated again. Seeing this, of even having a redeploy program object-task would be helpful.

Updated idea status Needs feedback → Open

Hi Roy,

With the next version (2023.1) of the Software Factory, we have brought improvements to the Code review and its details. This includes an overview of all changes of a Control procedure; even before it is set in review. This will allow you to see what changes are made to the control procedure.

In addition, comments can be linked to Templates which will make it more easy to see what to change in which template.

Does that suffice for your wish? We hope to hear from you soon.

Open→Next release
Next release→Completed
Terms & ConditionsCookie settings