Skip to main content
Working on it!

Possibility to review more than just code

Related products:Software Factory
  • July 24, 2019
  • 11 replies
  • 358 views

K.Bakkenes
Captain
Forum|alt.badge.img+9
We regularly see expression columns or prefilter with heavy constructs that effect the performance. So it would be nice if we can review expression columns and prefilter just like control procedures.
Which would include the following features:
· Approve/disapprove prefilters and expression columns
· Add comments when disapproving prefilters and expression columns

11 replies

Jasper
Superhero
  • August 13, 2019

We decided not to implement this idea as requested above.

However, we would prefer to extend this even further and make it possible to review and comment on all changes to a model. We already have plans to optimize the branching mechanism so that we can provide a pull request-like mechanism, similar to GIT for example.


Jeroen van den Belt
Administrator
Forum|alt.badge.img+10
The following idea has been merged into this idea:

All the votes have been transferred into this idea.

Jeroen van den Belt
Administrator
Forum|alt.badge.img+10
The following idea has been merged into this idea:

All the votes have been transferred into this idea.

Jeroen van den Belt
Administrator
Forum|alt.badge.img+10
The following idea has been merged into this idea:

All the votes have been transferred into this idea.

Arie V
Community Manager
Forum|alt.badge.img+12
  • Community Manager
  • January 2, 2025
On the backlogOpen

Arie V
Community Manager
Forum|alt.badge.img+12
  • Community Manager
  • January 2, 2025

Status updated to better reflect the Status of the Idea with the clarified Statuses as explained in the Reply here: What happens to your ideas? (updated as per november 2024) | Thinkwise Community


Arie V
Community Manager
Forum|alt.badge.img+12
  • Community Manager
  • June 11, 2025
OpenOn the backlog

Forum|alt.badge.img
  • Rookie
  • August 15, 2025

Is there any indication when this might be implemented?


Mark Jongeling
Administrator
Forum|alt.badge.img+23

Is there any indication when this might be implemented?

We are currently in the design phase of this idea. I have written quite an extensive design document that includes more than this idea mentions. Once we have agreed upon what is in scope for the implementation, I expect the idea will be processed in 2026.1.


Mark Jongeling
Administrator
Forum|alt.badge.img+23
On the backlogWorking on it!

Balazs Szeder
Apprentice

I want to suggest combining this ticket with another idea I shared about tracking and exporting all changes made since a branch was created. This ticket is already in progress with plans for a review system like Git pull requests. It would be great to add a feature in the Software Factory that exports a clear summary of all changes. This export could be simple, like copy to clipboard, showing changes formatted like this:

Functionality

  • (new) vw_test_overview
  • (modified) func_auto_raise_my_salary
  • (deleted) hnd_no_changes_to_salary

Data model

  • (new) test_overview

Subjects

  • test_overview
    • Data
      • Prefilter
        • (new) my_test

This makes it easy to copy and paste into JIRA, etc. It saves time and keeps documentation consistent. It helps everyone stay aligned and speeds up debugging. It also reduces the pain of manual docs. 

For more details, here is my original ticket: