When you have created / adjusted functionality and as a consequence also created a unit test, the functionality can be send to the review process. Also, you can see the (results of) the linked unit tests.
At the moment, the unit test itself is not a part of the review process. To improve quality, I suggest to make unit tests be part of the review process.
+23Hi Jeroen,
I miss the preferred solution, how would you like this to work inside the Review process? Like, that approving the Review cannot be done until the Unit tests are successful? How would the Code review process should handle Control procedures that do not have or cannot have Unit tests, such as Views?
Looking forward to your suggestions 😄
Hi Mark, thank you for your quick response. The fact that a unit test has a successful result does not mean that the unit test is correct. I have seen some unit tests always resulting in a success, even when the functionality was functionally wrong. There needs to be a second opinion on unit tests as well, just like the functionality needs a second opinion.
+23We do have the Unit tests detail part of the Code review screen but not strictly part of the Review process. The badge indicates the number of Unit tests present.
I do feel the Review process should be a process supported by the development team. If the team decides Unit tests should be double checked as part of the Review, then this detail tabpage can help them out.
I'll discuss with my colleagues to see if we want to make Unit tests a true part of the Code review process.
+9
Enter your E-mail address. We'll send you an e-mail with instructions to reset your password.
