Skip to main content
Completed

Code review items per template

Related products:Software Factory
Thijs Holterman
K.Bakkenes
Jeroen van den Belt
Mark Jongeling
+16
  • Thijs Holterman
    Thijs Holterman
  • K.Bakkenes
    K.Bakkenes
  • Jeroen van den Belt
    Jeroen van den Belt
  • Maurice Liebregt
  • Mark Jongeling
    Mark Jongeling
  • Willem Verhoef
  • Mark van Benthem
  • Ruben
    Ruben
  • Ricky
    Ricky
  • Gaby Ewald
    Gaby Ewald
  • Roy van Uffelen
  • Arie V
    Arie V
  • g.c.d.vanderschoot
  • J. de Lange
    J. de Lange
  • Suleyman
  • KeesTap
  • Shawn Adrian Diño
  • Marc Meijerink
  • BrechtvGils
  • HarryA
  • BramG

K.Bakkenes
Captain

Currently the ‘Code reviews’ screen shows code reviews per control procedure. Templates within a control procedure can be changed by different developers. 
We would like to see every control procedure template as an individual code review item. This would allow a reviewer to approve or disapprove a single template. This will also allow you to see at a glance which templates must be reviewed without having to look in the tabpage 'Changes’.

Did this topic help you find an answer to your question?

4 replies

Jeroen van den Belt
Administrator
Forum|alt.badge.img+9
Updated idea status NewOpen

Mark Jongeling
Administrator
Forum|alt.badge.img+23

Hi Kevin,

Regarding your idea, we haven't implemented this idea for the next version. However, with the next version (2023.1) of the Software Factory, we have brought improvements to the Code review and its details. This includes an overview of all changes of a Control procedure; even before it is set in review. This will allow you to see what changes are made to the control procedure.

In addition, comments can be linked to Templates which will make it more easy to see what to change in which template.

Having the ability to approve single templates whilst disapproving others is still a nice idea, but it didn't fit the refactor as it requires more changes to the data model of the Software Factory to allow for this process.


Jeroen van den Belt
Administrator
Forum|alt.badge.img+9

In the 2023.1 comments can be linked to templates, which will make it more easy to see what to change in which template. This should already help in the review process. We will therefore close this idea. If the ability to really approve/disapprove individual templates still exists after using the 2023.1, we recommend creating a separate idea for this.


Jeroen van den Belt
Administrator
Forum|alt.badge.img+9
OpenCompleted

Reply


Cookie policy

We use cookies to enhance and personalize your experience. If you accept you agree to our full cookie policy. Learn more about our cookies.

 
Cookie settings